From 8b996885d18189a0d53c98a30f74850059ab004c Mon Sep 17 00:00:00 2001
From: Benjamin Renard <brenard@easter-eggs.com>
Date: Tue, 17 Nov 2020 17:56:04 +0100
Subject: [PATCH] LSsession: improve loadLSaddons() method

---
 src/includes/class/class.LSsession.php | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/includes/class/class.LSsession.php b/src/includes/class/class.LSsession.php
index 2449f128..c680fdf2 100644
--- a/src/includes/class/class.LSsession.php
+++ b/src/includes/class/class.LSsession.php
@@ -557,24 +557,25 @@ class LSsession {
   }
 
  /**
-  * Chargement des addons LdapSaisie
+  * Load globally required LSaddons
   *
-  * Chargement des LSaddons contenue dans la variable
-  * $GLOBALS['LSaddons']['loads']
+  * Load LSaddons list in $GLOBALS['LSaddons']['loads']
   *
-  * @retval boolean true si le chargement a réussi, false sinon.
+  * @retval boolean True on success, False otherwise
   */
   public static function loadLSaddons() {
-    $conf=LSconfig :: get('LSaddons.loads');
+    $conf = LSconfig :: get('LSaddons.loads');
     if(!is_array($conf)) {
       LSerror :: addErrorCode('LSsession_01',"LSaddons['loads']");
       return;
     }
 
+    $error = false;
     foreach ($conf as $addon) {
-      self :: loadLSaddon($addon);
+      if (!self :: loadLSaddon($addon))
+        $false = true;
     }
-    return true;
+    return !$error;
   }