From 34d7e10f9a36119a33ff6b56466172bff1237971 Mon Sep 17 00:00:00 2001
From: Benjamin Renard <brenard@easter-eggs.com>
Date: Wed, 19 Aug 2020 15:35:18 +0200
Subject: [PATCH] Log referer URL in case of old-style URL redirection

---
 src/includes/class/class.LSurlRequest.php |  13 +++
 src/includes/routes.php                   | 100 ++++++++++++++++++++++
 2 files changed, 113 insertions(+)

diff --git a/src/includes/class/class.LSurlRequest.php b/src/includes/class/class.LSurlRequest.php
index 974f787f..d3325552 100644
--- a/src/includes/class/class.LSurlRequest.php
+++ b/src/includes/class/class.LSurlRequest.php
@@ -60,6 +60,8 @@ class LSurlRequest {
       return $this -> handler;
     if ($key == 'authenticated')
       return $this -> authenticated;
+    if ($key == 'referer')
+      return $this -> get_referer();
     if (array_key_exists($key, $this->url_params)) {
       return urldecode($this->url_params[$key]);
     }
@@ -78,4 +80,15 @@ class LSurlRequest {
     return array_key_exists($key, $this->url_params);
   }
 
+  /*
+   * Get request referer (if known)
+   *
+   * @retval string|null The request referer URL if known, null otherwise
+   */
+  public function get_referer() {
+    if (isset($_SERVER['HTTP_REFERER']) && $_SERVER['HTTP_REFERER'])
+      return $_SERVER['HTTP_REFERER'];
+    return null;
+  }
+
 }
diff --git a/src/includes/routes.php b/src/includes/routes.php
index e550bda9..ef6f0955 100644
--- a/src/includes/routes.php
+++ b/src/includes/routes.php
@@ -110,6 +110,16 @@ LSurl :: add_handler('#^ajax/(?P<type>class|addon)/(?P<type_value>[^/]+)/(?P<act
  **/
 function handle_old_index_ajax_php($request) {
   LSerror :: addErrorCode('LSsession_26', 'index_ajax.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => 'Redirection unsupported',
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSsession :: displayAjaxReturn(null);
 }
 LSurl :: add_handler('#^index_ajax\.php#', 'handle_old_index_ajax_php');
@@ -229,6 +239,16 @@ function handle_old_global_search_php($request) {
       $url .= "&refresh";
   }
   LSerror :: addErrorCode('LSsession_26', 'global_search.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^global_search\.php#', 'handle_old_global_search_php');
@@ -605,6 +625,16 @@ function handle_old_custom_search_action_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/customAction/".$_GET['customAction'];
   LSerror :: addErrorCode('LSsession_26', 'custom_search_action.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^custom_search_action\.php#', 'handle_old_custom_search_action_php');
@@ -711,6 +741,16 @@ function handle_old_select_php($request) {
     $url = "object/".$_GET['LSobject'];
   }
   LSerror :: addErrorCode('LSsession_26', 'select.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'LSobject parameter is missing to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^select\.php#', 'handle_old_select_php');
@@ -773,6 +813,16 @@ function handle_old_import_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/import";
   LSerror :: addErrorCode('LSsession_26', 'import.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^import\.php#', 'handle_old_import_php');
@@ -896,6 +946,16 @@ function handle_old_create_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/create";
   LSerror :: addErrorCode('LSsession_26', 'create.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^create\.php#', 'handle_old_create_php');
@@ -992,6 +1052,16 @@ function handle_old_view_php($request) {
   else
     $url = "object/".$_GET['LSobject'];
   LSerror :: addErrorCode('LSsession_26', 'view.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^view\.php#', 'handle_old_view_php');
@@ -1100,6 +1170,16 @@ function handle_old_modify_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/".$_GET['dn']."/modify";
   LSerror :: addErrorCode('LSsession_26', 'modify.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^modify\.php#', 'handle_old_modify_php');
@@ -1180,6 +1260,16 @@ function handle_old_remove_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/".$_GET['dn']."/remove";
   LSerror :: addErrorCode('LSsession_26', 'remove.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^remove\.php#', 'handle_old_remove_php');
@@ -1306,6 +1396,16 @@ function handle_old_custom_action_php($request) {
   else
     $url = "object/".$_GET['LSobject']."/".$_GET['dn']."/customAction/".$_GET['customAction'];
   LSerror :: addErrorCode('LSsession_26', 'custom_action.php');
+  LSlog :: warning(
+    getFData(
+      "Handling old URL style redirection:\n - Requested URL: '%{old}'\n - Redirection URL: '%{new}'\n - Referer: %{referer}",
+      array (
+        'old' => $request -> current_url,
+        'new' => ($url?$url:'missing parameter to compose URL'),
+        'referer' => ($request -> referer?"'".$request -> referer."'":'Unknown (direct access or hidden by web-browser)'),
+      )
+    )
+  );
   LSurl :: redirect($url);
 }
 LSurl :: add_handler('#^custom_action\.php#', 'handle_old_custom_action_php');