From 338c61838f8c977940f0cbda12c59bb061a87833 Mon Sep 17 00:00:00 2001
From: Benjamin Renard <brenard@easter-eggs.com>
Date: Mon, 4 May 2020 11:53:12 +0200
Subject: [PATCH] Fix templates PHP warning

---
 public_html/templates/default/LSdefault.tpl   |  6 +--
 public_html/templates/default/LSform.tpl      | 38 +++++++++----------
 .../default/LSformElement_uri_field.tpl       |  2 +-
 public_html/templates/default/LSform_view.tpl | 18 ++++-----
 public_html/templates/default/LSrelations.tpl |  8 ++--
 public_html/templates/default/top.tpl         |  2 +-
 public_html/templates/default/view.tpl        |  8 ++--
 7 files changed, 42 insertions(+), 40 deletions(-)

diff --git a/public_html/templates/default/LSdefault.tpl b/public_html/templates/default/LSdefault.tpl
index ff0d40ed..42466c32 100644
--- a/public_html/templates/default/LSdefault.tpl
+++ b/public_html/templates/default/LSdefault.tpl
@@ -1,6 +1,6 @@
 <div id='LSjsConfig'>{$LSjsConfig}</div>
 
-<div id='LSinfos_txt'>{if is_array($LSinfos) && !empty($LSinfos)}
+<div id='LSinfos_txt'>{if isset($LSinfos) && is_array($LSinfos) && !empty($LSinfos)}
 <ul>
 {foreach $LSinfos as $info}
 <li>{$info|escape:"htmlall"}</li>
@@ -8,9 +8,9 @@
 </ul>
 {/if}</div>
 
-<div id='LSerror_txt'>{$LSerrors}</div>
+<div id='LSerror_txt'>{if isset($LSerrors) && $LSerrors}{$LSerrors}{/if}</div>
 
-<div id='LSdebug_txt'>{if $LSdebug != ''}{$LSdebug}{/if}</div>
+<div id='LSdebug_txt'>{if isset($LSdebug) && $LSdebug}{$LSdebug}{/if}</div>
 
 <div id="_smarty_console"></div>
 
diff --git a/public_html/templates/default/LSform.tpl b/public_html/templates/default/LSform.tpl
index 1bb3d835..ba47e860 100644
--- a/public_html/templates/default/LSform.tpl
+++ b/public_html/templates/default/LSform.tpl
@@ -1,6 +1,6 @@
 <form action='{$LSform_action}' method='post' enctype="multipart/form-data" class='LSform'>
 {$LSform_header}
-{if $LSform_layout}
+{if isset($LSform_layout) && $LSform_layout}
   <!-- Tabs - Start Title -->
   <ul class='LSform_layout'>
   {foreach from=$LSform_layout item=tab key=tab_key}
@@ -14,9 +14,9 @@
     <a name='{$tab_key|escape:'htmlall'}'></a>
     <h2 class='LSform_layout'>{tr msg=$tab.label}</h2>
     <div class='LSform LSform_layout' id='LSform_layout_div_{$tab_key|escape:'htmlall'}'>
-      {if $LSformElement_image!='' && $tab.img==1}
-      <div class='LSformElement_image{if $LSformElement_image_errors} LSformElement_image_errors{/if}'>
-        {if $LSformElement_image_actions!='' && !$LSformElement_image_errors}
+      {if isset($LSformElement_image) && $LSformElement_image!='' && isset($tab['img']) && $tab.img==1}
+      <div class='LSformElement_image{if isset($LSformElement_image_errors) && $LSformElement_image_errors} LSformElement_image_errors{/if}'>
+        {if isset($LSformElement_image_actions) && $LSformElement_image_actions!='' && !(isset($LSformElement_image_errors) && $LSformElement_image_errors)}
         <ul class='LSformElement_image_actions'>
             <li><img src='{img name="zoom"}' class='LSformElement_image_actions LSformElement_image_action_zoom' id='LSformElement_image_action_zoom_{$LSformElement_image.id|escape:'htmlall'}' /></li>
           {foreach from=$LSformElement_image_actions item=item}
@@ -27,13 +27,13 @@
         <img src='{$LSformElement_image.img}' class='LSformElement_image LSsmoothbox' id='LSformElement_image_{$LSformElement_image.id|escape:'htmlall'}' />
       </div>
       {/if}
-      
+
       <dl class='LSform'>
         {foreach from=$tab.args item=arg}
-          {if $LSform_fields[$arg]}
-            <dt class='LSform{if $LSform_fields[$arg].errors != ''} LSform-errors{/if}'>{$LSform_fields[$arg].label}{if $LSform_fields[$arg].required} *{/if}{if $LSform_fields[$arg].help_info!=""} <img class='LStips' src="{img name='help'}" alt='?' title='{$LSform_fields[$arg].help_info|escape:'htmlall'}'/>{/if}</dt>
-            <dd class='LSform'>{$LSform_fields[$arg].html}{if $LSform_fields[$arg].add != ''} <span class='LSform-addfield'>+ Ajouter un champ</span>{/if}</dd>
-            {if $LSform_fields[$arg].errors != ''}
+          {if isset($LSform_fields[$arg])}
+            <dt class='LSform{if isset($LSform_fields[$arg]['errors']) && $LSform_fields[$arg]['errors']} LSform-errors{/if}'>{$LSform_fields[$arg].label}{if isset($LSform_fields[$arg]['required']) && $LSform_fields[$arg]['required']} *{/if}{if isset($LSform_fields[$arg]['help_info']) && $LSform_fields[$arg]['help_info']} <img class='LStips' src="{img name='help'}" alt='?' title='{$LSform_fields[$arg].help_info|escape:'htmlall'}'/>{/if}</dt>
+            <dd class='LSform'>{$LSform_fields[$arg].html}{if isset($LSform_fields[$arg]['add']) && $LSform_fields[$arg]['add']} <span class='LSform-addfield'>+ Ajouter un champ</span>{/if}</dd>
+            {if isset($LSform_fields[$arg]['errors']) && $LSform_fields[$arg]['errors']}
               {foreach from=$LSform_fields[$arg].errors item=error}
               <dd class='LSform LSform-errors'>{$error|escape:'htmlall'}</dd>
               {/foreach}
@@ -42,14 +42,14 @@
         {/foreach}
         <dd class='LSform'><input type='submit' value='{$LSform_submittxt|escape:'htmlall'}' class='LSform' /></dd>
       </dl>
-      
+
     </div>
-  {/foreach}  
+  {/foreach}
   <!-- Tabs - End Content -->
 {else}
-  {if $LSformElement_image!=''}
-    <div class='LSformElement_image{if $LSformElement_image_errors} LSformElement_image_errors{/if}'>
-      {if $LSformElement_image_actions!='' && !$LSformElement_image_errors}
+  {if isset($LSformElement_image) && $LSformElement_image!=''}
+    <div class='LSformElement_image{if isset($LSformElement_image_errors) && $LSformElement_image_errors} LSformElement_image_errors{/if}'>
+      {if isset($LSformElement_image_actions) && $LSformElement_image_actions!='' && !(isset($LSformElement_image_errors) && $LSformElement_image_errors)}
       <ul class='LSformElement_image_actions'>
           <li><img src='{img name='zoom'}' class='LSformElement_image_actions LSformElement_image_action_zoom' id='LSformElement_image_action_zoom_{$LSformElement_image.id|escape:'htmlall'}' /></li>
         {foreach from=$LSformElement_image_actions item=item}
@@ -60,13 +60,13 @@
       <img src='{$LSformElement_image.img}' class='LSformElement_image LSsmoothbox' id='LSformElement_image_{$LSformElement_image.id|escape:'htmlall'}' />
     </div>
   {/if}
-  
+
   <div class='LSform'>
     <dl class='LSform'>
       {foreach from=$LSform_fields item=field}
-      <dt class='LSform{if $field.errors != ''} LSform-errors{/if}'>{$field.label}{if $field.required} *{/if}{if $field.help_info!=""} <img class='LStips' src="{img name='help'}" alt='?' title='{$field.help_info|escape:'htmlall'}'/>{/if}</dt>
-      <dd class='LSform'>{$field.html}{if $field.add != ''} <span class='LSform-addfield'>+ Ajouter un champ</span>{/if}</dd>
-      {if $field.errors != ''}
+      <dt class='LSform{if isset($field['errors']) && $field['errors']} LSform-errors{/if}'>{$field.label}{if isset($field['required']) && $field['required']} *{/if}{if isset($field['help_info']) && $field['help_info']} <img class='LStips' src="{img name='help'}" alt='?' title='{$field.help_info|escape:'htmlall'}'/>{/if}</dt>
+      <dd class='LSform'>{$field.html}{if isset($field['add']) && $field['add']} <span class='LSform-addfield'>+ Ajouter un champ</span>{/if}</dd>
+      {if isset($field['errors']) && $field['errors']}
         {foreach from=$field.errors item=error}
         <dd class='LSform LSform-errors'>{$error|escape:'htmlall'}</dd>
         {/foreach}
@@ -75,6 +75,6 @@
       <dd class='LSform'><input type='submit' value='{$LSform_submittxt|escape:"htmlall"}' class='LSform' /></dd>
     </dl>
   </div>
-  
+
 {/if}
 </form>
diff --git a/public_html/templates/default/LSformElement_uri_field.tpl b/public_html/templates/default/LSformElement_uri_field.tpl
index 17262653..a3328570 100644
--- a/public_html/templates/default/LSformElement_uri_field.tpl
+++ b/public_html/templates/default/LSformElement_uri_field.tpl
@@ -1,7 +1,7 @@
 {if $freeze}
   <span class='LSformElement_text'>
   {if $value}
-    <a class='{$uriClass|escape:"htmlall"}' href='{$uriPrefix|escape:"htmlall"}{$value|escape:"htmlall"}'{if $uriLinkTitle} title='{$uriLinkTitle|escape:"htmlall"}'{/if}{if $uriTarget} target='{$uriTarget|escape:"htmlall"}'{/if}>{$value|escape:"htmlall"}</a>
+    <a class='{$uriClass|escape:"htmlall"}' href='{$uriPrefix|escape:"htmlall"}{$value|escape:"htmlall"}'{if isset($uriLinkTitle) && $uriLinkTitle} title='{$uriLinkTitle|escape:"htmlall"}'{/if}{if isset($uriTarget) && $uriTarget} target='{$uriTarget|escape:"htmlall"}'{/if}>{$value|escape:"htmlall"}</a>
   {else}
     {$noValueTxt|escape:"htmlall"}
   {/if}
diff --git a/public_html/templates/default/LSform_view.tpl b/public_html/templates/default/LSform_view.tpl
index 75f339ff..ac470c43 100644
--- a/public_html/templates/default/LSform_view.tpl
+++ b/public_html/templates/default/LSform_view.tpl
@@ -1,6 +1,6 @@
 <input type='hidden' name='LSform_objecttype' id='LSform_objecttype'  value='{$LSform_object.type|escape:"htmlall"}'/>
 <input type='hidden' name='LSform_objectdn' id='LSform_objectdn'  value='{$LSform_object.dn|escape:"htmlall"}'/>
-{if $LSform_layout}
+{if isset($LSform_layout) && $LSform_layout}
   <!-- Tabs - Start Title -->
   <ul class='LSform_layout'>
   {foreach from=$LSform_layout item=tab key=tab_key}
@@ -14,17 +14,17 @@
     <a name='{$tab_key|escape:"htmlall"}'></a>
     <h2 class='LSform_layout'>{$tab.label|escape:"htmlall"}</h2>
     <div class='LSform LSform_layout' id='LSform_layout_div_{$tab_key|escape:"htmlall"}'>
-    
-      {if $LSformElement_image!='' && $tab.img==1}
+
+      {if isset($LSformElement_image) && $LSformElement_image!='' && isset($tab['img']) && $tab.img==1}
         <div class='LSformElement_image'>
           <a href='{$LSformElement_image.img|escape:"htmlall"}' rel='rien ici' title='comment' class='mb'><img src='{$LSformElement_image.img|escape:"htmlall"}' class='LSformElement_image LSsmoothbox' id='LSformElement_image_{$LSformElement_image.id|escape:"htmlall"}' /></a>
         </div>
       {/if}
-      
+
       <dl class='LSform'>
         {assign var='field' value='non'}
         {foreach from=$tab.args item=arg}
-          {if $LSform_fields[$arg]}
+          {if isset($LSform_fields[$arg])}
             {assign var='field' value='oui'}
             <dt class='LSform'>{$LSform_fields[$arg].label|escape:"htmlall"}{if $LSform_fields[$arg].help_info_in_view && $LSform_fields[$arg].help_info!=""} <img class='LStips' src="{img name='help'}" alt='?' title='{$LSform_fields[$arg].help_info|escape:'htmlall'}'/>{/if}</dt>
             <dd class='LSform'>{$LSform_fields[$arg].html}</dd>
@@ -34,13 +34,13 @@
           <dd class='LSform'>{$LSform_layout_nofield_label|escape:"htmlall"}</dd>
         {/if}
       </dl>
-      
+
     </div>
-  {/foreach}  
+  {/foreach}
   <!-- Tabs - End Content -->
 {else}
 
-  {if $LSformElement_image!=''}
+  {if isset($LSformElement_image) && $LSformElement_image!=''}
   <div class='LSformElement_image'>
     <a href='{$LSformElement_image.img|escape:"htmlall"}' rel='rien ici' title='comment' class='mb'><img src='{$LSformElement_image.img|escape:"htmlall"}' class='LSformElement_image LSsmoothbox' id='LSformElement_image_{$LSformElement_image.id|escape:"htmlall"}' /></a>
   </div>
@@ -54,5 +54,5 @@
       {/foreach}
     </dl>
   </div>
-   
+
 {/if}
diff --git a/public_html/templates/default/LSrelations.tpl b/public_html/templates/default/LSrelations.tpl
index 88d7ae6d..9e4c0605 100644
--- a/public_html/templates/default/LSrelations.tpl
+++ b/public_html/templates/default/LSrelations.tpl
@@ -7,9 +7,11 @@
   </ul>
 {/if}
 <ul id='LSrelation_ul_{$item.id|escape:"quotes"}' class='LSrelation'>
-{foreach from=$item.objectList item=object}
+{if isset($item['objectList']) && !empty($item.objectList)}
+  {foreach from=$item.objectList item=object}
   <li class='LSrelation'><a href='object/{$item.LSobject|escape:"url"}/{$object.dn|escape:'url'}' class='LSrelation{if $object.canEdit} LSrelation_editable{/if}' id='LSrelation_{$item.id|escape:"quotes"}_{$object.dn|escape:"quotes"}'>{$object.text|escape:"htmlall"}</a></li>
-{foreachelse}
+  {/foreach}
+{else}
   <li class='LSrelation'>{$item.emptyText|escape:"htmlall"}</li>
-{/foreach}
+{/if}
 </ul>
diff --git a/public_html/templates/default/top.tpl b/public_html/templates/default/top.tpl
index 109c6ae8..ffd779e2 100644
--- a/public_html/templates/default/top.tpl
+++ b/public_html/templates/default/top.tpl
@@ -19,7 +19,7 @@
     <td rowspan=2 id='left'>
       <a href='index.php'><img src='{img name='logo'}' alt='Logo' id='logo'/></a>
 
-      {if $LSsession_subDn!=""}
+      {if isset($LSsession_subDn) && $LSsession_subDn!=""}
         <form action="index.php" method='post' id='LSsession_topDn_form'>
           <label>{$label_level|escape:"htmlall"}
             <a href="index.php?LSsession_refresh"><img src='{img name='refresh'}' alt='{$_refresh|escape:"htmlall"}' title='{$_refresh|escape:"htmlall"}' /></a>
diff --git a/public_html/templates/default/view.tpl b/public_html/templates/default/view.tpl
index b8a3107c..6e8094ea 100644
--- a/public_html/templates/default/view.tpl
+++ b/public_html/templates/default/view.tpl
@@ -4,15 +4,15 @@
     <ul class='LSview-actions'>
       {foreach from=$LSview_actions item=item}
         {if is_array($item)}
-        <li class='LSview-actions'><a href='{$item.url}' class='LSview-actions{if $item.class} {$item.class|escape:"quotes"}{/if}{if $item.helpInfo || ($item.hideLabel && $item.label)} LStips{/if}' {if $item.helpInfo || ($item.hideLabel && $item.label)}title='{if $item.helpInfo}{$item.helpInfo|escape:"htmlall"}{else}{$item.label|escape:"htmlall"}{/if}'{/if}><img src="{img name=$item.action}" alt='{$item.label|escape:"htmlall"}' title='{$item.label|escape:"htmlall"}' />{if !isset($item.hideLabel) || !$item.hideLabel} {$item.label}{/if}</a></li>
+        <li class='LSview-actions'><a href='{$item.url}' class='LSview-actions{if isset($item['class'])} {$item.class|escape:"quotes"}{/if}{if isset($item['helpInfo']) || (isset($item['hideLabel']) && $item.hideLabel && isset($item.label) && $item.label)} LStips{/if}' {if isset($item['helpInfo']) || (isset($item['hideLabel']) && $item.hideLabel && isset($item.label) && $item.label)}title='{if $item.helpInfo}{$item.helpInfo|escape:"htmlall"}{else}{$item.label|escape:"htmlall"}{/if}'{/if}><img src="{img name=$item.action}" alt='{$item.label|escape:"htmlall"}' title='{$item.label|escape:"htmlall"}' />{if !isset($item.hideLabel) || !$item.hideLabel} {$item.label}{/if}</a></li>
         {/if}
       {/foreach}
     </ul>
     {/if}
-    
+
     {include file='ls:LSform_view.tpl'}
-    
-    {if $LSrelations!=''}
+
+    {if isset($LSrelations) && $LSrelations}
       {foreach from=$LSrelations item=item}
         {include file='ls:LSrelations.tpl'}
       {/foreach}