From 29e499e1d6150ec85ad04d1d18ac7deb7fd8f99b Mon Sep 17 00:00:00 2001
From: Benjamin Renard <brenard@easter-eggs.com>
Date: Thu, 28 Jan 2021 16:59:42 +0100
Subject: [PATCH] LSldapObject::submitChange(): fix error renaming LSobject

Old RDN value was keep and block the update ot the other changed
attributes.
---
 src/includes/class/class.LSldapObject.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/includes/class/class.LSldapObject.php b/src/includes/class/class.LSldapObject.php
index fcc92781..a13986a3 100644
--- a/src/includes/class/class.LSldapObject.php
+++ b/src/includes/class/class.LSldapObject.php
@@ -640,7 +640,6 @@ class LSldapObject extends LSlog_staticLoggerClass {
     foreach($this -> attrs as $attr) {
       if(($attr -> isUpdate())&&($attr -> isValidate())) {
         if(($attr -> name == $this -> getConfig('rdn')) && (!$new)) {
-          $new = true;
           self :: log_debug("$this -> submitChange($idForm): renaming detected");
           if (!$this -> fireEvent('before_rename')) {
             LSerror :: addErrorCode('LSldapObject_16');
@@ -650,8 +649,9 @@ class LSldapObject extends LSlog_staticLoggerClass {
           $this -> dn = false;
           $newDn = $this -> getDn();
           if ($newDn) {
-            self :: log_debug("$this -> submitChange($idForm): Rename me to '$newDn'");
-            if (!LSldap :: move($oldDn,$newDn)) {
+            self :: log_debug("$this -> submitChange($idForm): Rename me from '$oldDn' to '$newDn'");
+            if (!LSldap :: move($oldDn, $newDn)) {
+              self :: log_error("$this -> submitChange($idForm): Fail to rename me from '$oldDn' to '$newDn'. Stop.");
               return;
             }
             $this -> dn = $newDn;