Add some pre-commit hooks

.pre-commit-config.yaml

@@ -0,0 +1,29 @@
+# Pre-commit hooks to run tests and ensure code is cleaned.
+# See https://pre-commit.com for more information
+---
+repos:
+  - repo: https://github.com/codespell-project/codespell
+    rev: v2.2.2
+    hooks:
+      - id: codespell
+        args:
+          - --ignore-words-list=exten
+          - --skip="./.*,*.csv,*.json,*.ini,*.subject,*.txt,*.html,*.log,*.conf"
+          - --quiet-level=2
+          - --ignore-regex=.*codespell-ignore$
+          # - --write-changes  # Uncomment to write changes
+        exclude_types: [csv, json]
+  - repo: https://github.com/pre-commit/mirrors-prettier
+    rev: v2.7.1
+    hooks:
+      - id: prettier
+        args: ["--print-width", "100"]
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.32.0
+    hooks:
+      - id: yamllint
+        ignore: .github/
+  - repo: https://github.com/shellcheck-py/shellcheck-py
+    rev: v0.10.0.1
+    hooks:
+      - id: shellcheck

README.md

@@ -1,28 +1,24 @@
-Nagios/Icinga check plugins for BackupPC
+# Nagios/Icinga check plugins for BackupPC
-========================================
 
-This repository compile some usefull Nagios/Icinga check plugins for BackupPC :
+This repository compile some useful Nagios/Icinga check plugins for BackupPC :
 
-* *check_backuppc\* :* Check the age of the last backup
+-   _check_backuppc\* :_ Check the age of the last backup
-* *check_backuppc_du :* Check disk space use by backups
+-   _check_backuppc_du :_ Check disk space use by backups
 
 \* This check plugins was fork from [_check_backuppc_](https://sourceforge.net/projects/n-backuppc/) (version 1.1.0) write by Seneca Cunningham <tetragon@users.sourceforge.net>.
 
-Compatibility
+## Compatibility
--------------
 
 This check plugins have been successfully test with BackupPC 3 (3.2.1) and 4 (4.1.5).
 
-Copyright
+## Copyright
----------
 
 Copyright (c) 2018 Easter-eggs
 
-License
+## License
--------
 
 This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License version 3 as published by the Free Software Foundation.
 
-This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
 
-You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.

check_backuppc

@@ -82,7 +82,7 @@ $goodOpt = GetOptions(
 @hostsDesired = () if $#hostsDesired < 0;
 @hostsExcluded = () if $#hostsExcluded < 0;
 
-# Always check disabled host if a named host is provided (when backup is trigerred by cron)
+# Always check disabled host if a named host is provided (when backup is triggered by cron)
 $forceCheckOnDisabledHosts = 1 if ( @hostsDesired && scalar(@hostsDesired) );
 
 if ($opt_V)

check_backuppc_du

@@ -105,7 +105,7 @@ my $hosts_infos = $server->HostInfoRead();
 # undump the output... BackupPC uses Data::Dumper
 eval $status_raw;
 
-# Allow hostname separeted by comma
+# Allow hostname separated by comma
 @hostlist = split(/,/,join(',',@hostlist));
 
 my $per_host_detail;

check_backuppc_nb_bkp_v3

@@ -1,6 +1,10 @@
 #!/bin/bash
 
-cd /var/lib/backuppc/pc
+[[ ! -d /var/lib/backuppc/pc ]] && echo "BackupPC directory not found (/var/lib/backuppc/pc)." && exit 1
+if ! cd "/var/lib/backuppc/pc"; then
+    echo "Failed to enter in BackupPC directory (/var/lib/backuppc/pc)."
+    exit 1
+fi
 
 OUT="<table align=center>
 <thead>
@@ -15,18 +19,19 @@ OUT="<table align=center>
 <tbody>"
 t_v3=0
 t_v4=0
-for h in *
+for h in *; do
-do
+    if [[ ! -d "$h" ]] || [[ ! -e "$h/backups" ]]; then
-	[ ! -d "$h" -o ! -e "$h/backups" ] && continue
+        continue
-	vers=$( cat $h/backups|cut -f24 )
+    fi
-	v3=$( echo -e "$vers"|grep -Ev '^4'|wc -l|cut -f1 )
+    vers=$( cut -f24 < "$h/backups" )
-	let t_v3=t_v3+v3
+    v3=$( grep -Evc '^4' <<< "$vers" )
-	[ $v3 -ne 0 ] && v3="<strong>$v3</strong>"
+    ((t_v3=t_v3+v3))
-	v4=$( echo -e "$vers"|grep -Ec '^4' )
+    [[ "$v3" -ne 0 ]] && v3="<strong>$v3</strong>"
-	let t_v4=t_v4+v4
+    v4=$( grep -Ec '^4' <<< "$vers" )
-	OUT="$OUT<tr><td align=left>$h</td><td>$v3</td><td>$v4</td></tr>"
+    ((t_v4=t_v4+v4))
+    OUT="$OUT<tr><td align=left>$h</td><td>$v3</td><td>$v4</td></tr>"
 done
-[ $t_v3 -gt 0 ] && t_v3="<strong>$t_v3</strong>"
+[[ $t_v3 -gt 0 ]] && t_v3="<strong>$t_v3</strong>"
 OUT="$OUT
 </tbody>
 <tfooter>
@@ -37,4 +42,5 @@ OUT="$OUT
   </tr>
 </tfooter>
 </table>"
-echo $OUT|lynx -stdin
+lynx -stdin <<< "$OUT"
+# vim:set sw=4 ts=4 sts=4 ft=bash expandtab: