From 4bd371ea80b26b07a06abbae25fc811d2b47b4b6 Mon Sep 17 00:00:00 2001 From: Benjamin Renard Date: Mon, 7 Oct 2024 11:17:46 +0200 Subject: [PATCH] Use spaces instead of tabs for indentation --- .editorconfig | 15 +++ check_backuppc | 233 +++++++++++++++++++++++----------------------- check_backuppc_du | 118 +++++++++++------------ 3 files changed, 191 insertions(+), 175 deletions(-) create mode 100644 .editorconfig diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..a192365 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,15 @@ +root = true + +[*] +indent_style = space +indent_size = 4 +trim_trailing_whitespace = true +insert_final_newline = true +charset = utf-8 +end_of_line = lf + +[*.{yaml,yml}] +indent_size = 2 + +[Makefile] +indent_style = tab diff --git a/check_backuppc b/check_backuppc index 8d116be..bb2f5c6 100755 --- a/check_backuppc +++ b/check_backuppc @@ -65,53 +65,53 @@ my $critical_count = 0; # Process options $goodOpt = GetOptions( - 'v+' => \$verbose, 'verbose+' => \$verbose, - 'c=f' => \$critDaysOld, 'critical=f' => \$critDaysOld, - 'w=f' => \$warnDaysOld, 'warning=f' => \$warnDaysOld, - 'o=s' => \@ownerOnly, 'owner=s' => \@ownerOnly, - 'V' => \$opt_V, 'version' => \$opt_V, - 'h' => \$opt_h, 'help' => \$opt_h, - 'H=s' => \@hostsDesired, 'hostname=s' => \@hostsDesired, - 'x=s' => \@hostsExcluded, 'exclude=s' => \@hostsExcluded, - 'f' => \$forceCheckOnDisabledHosts, 'force=s' => \$forceCheckOnDisabledHosts); + 'v+' => \$verbose, 'verbose+' => \$verbose, + 'c=f' => \$critDaysOld, 'critical=f' => \$critDaysOld, + 'w=f' => \$warnDaysOld, 'warning=f' => \$warnDaysOld, + 'o=s' => \@ownerOnly, 'owner=s' => \@ownerOnly, + 'V' => \$opt_V, 'version' => \$opt_V, + 'h' => \$opt_h, 'help' => \$opt_h, + 'H=s' => \@hostsDesired, 'hostname=s' => \@hostsDesired, + 'x=s' => \@hostsExcluded, 'exclude=s' => \@hostsExcluded, + 'f' => \$forceCheckOnDisabledHosts, 'force=s' => \$forceCheckOnDisabledHosts); @hostsDesired = () if $#hostsDesired < 0; @hostsExcluded = () if $#hostsExcluded < 0; if ($opt_V) { - print "check_backuppc - " . $version . "\n"; - exit $ERRORS{'OK'}; + print "check_backuppc - " . $version . "\n"; + exit $ERRORS{'OK'}; } if ($opt_h or not $goodOpt) { - print "check_backuppc - " . $version . "\n"; - print "A Nagios plugin to check on BackupPC backup status.\n\n"; - print "Options:\n"; - print " --hostname,-H only check the specified host\n"; - print " --exclude,-x do not check the specified host\n"; - print " --owner,-o do only hosts of specified user\n"; - print " --force,-f force check even if host is disabled\n"; - print " --warning,-w days old of last good backup to cause a warning\n"; - print " --critical,-c days old of last good backup to be critical\n"; - print " --verbose,-v increase verbosity\n"; - print " --version,-V display plugin version\n"; - print " --help,-h display this message\n\n"; - exit $ERRORS{'OK'} if $goodOpt; - exit $ERRORS{'UNKNOWN'}; + print "check_backuppc - " . $version . "\n"; + print "A Nagios plugin to check on BackupPC backup status.\n\n"; + print "Options:\n"; + print " --hostname,-H only check the specified host\n"; + print " --exclude,-x do not check the specified host\n"; + print " --owner,-o do only hosts of specified user\n"; + print " --force,-f force check even if host is disabled\n"; + print " --warning,-w days old of last good backup to cause a warning\n"; + print " --critical,-c days old of last good backup to be critical\n"; + print " --verbose,-v increase verbosity\n"; + print " --version,-V display plugin version\n"; + print " --help,-h display this message\n\n"; + exit $ERRORS{'OK'} if $goodOpt; + exit $ERRORS{'UNKNOWN'}; } if ($warnDaysOld > $critDaysOld) { - print("BACKUPPC UNKNOWN - Warning threshold must be <= critical\n"); - exit $ERRORS{'UNKNOWN'}; + print("BACKUPPC UNKNOWN - Warning threshold must be <= critical\n"); + exit $ERRORS{'UNKNOWN'}; } # Connect to BackupPC my $server; if (!($server = BackupPC::Lib->new)) { - print "BACKUPPC CRITICAL - Couldn't connect to BackupPC\n"; - exit $ERRORS{'CRITICAL'}; + print "BACKUPPC CRITICAL - Couldn't connect to BackupPC\n"; + exit $ERRORS{'CRITICAL'}; } my %Conf = $server->Conf(); @@ -120,8 +120,8 @@ $server->ChildInit(); my $err = $server->ServerConnect($Conf{ServerHost}, $Conf{ServerPort}); if ($err) { - print("BACKUPPC UNKNOWN - Can't connect to server ($err)\n"); - exit $ERRORS{'UNKNOWN'}; + print("BACKUPPC UNKNOWN - Can't connect to server ($err)\n"); + exit $ERRORS{'UNKNOWN'}; } # query the BackupPC server for host status @@ -136,105 +136,106 @@ my $hostCount = 0; foreach my $host (@hostsDesired, @hostsExcluded) { - if (not grep {/^$host$/} keys(%Status)) - { - print("BACKUPPC UNKNOWN - Unknown host ($host)\n"); - exit $ERRORS{'UNKNOWN'}; - } + if (not grep {/^$host$/} keys(%Status)) + { + print("BACKUPPC UNKNOWN - Unknown host ($host)\n"); + exit $ERRORS{'UNKNOWN'}; + } } # host status checks foreach my $host (sort(keys(%Status))) { - next if $host =~ /^ /; - my $owner = $hosts_infos->{$host}->{user}; - next if (@ownerOnly and not grep {/$owner/} @ownerOnly); - my %host_conf = %{$server->ConfigDataRead($host)}; - $Status{$host}{BackupsDisable} = $host_conf{BackupsDisable}; - next if ( $Status{$host}{BackupsDisable} eq 2 and not $forceCheckOnDisabledHosts); - next if (@hostsDesired and not grep {/^$host$/} @hostsDesired); - next if (@hostsExcluded and grep {/^$host$/} @hostsExcluded); - next if ($Status{$host}{'type'} eq 'archive'); - $Status{$host}{'statusCode'} = 'OK'; - $hostCount++; - # Debug - if ($verbose == 2) - { - print "Host $host state " . $Status{$host}{'state'} . "\n"; - print " with reason: " . $Status{$host}{'reason'} . "\n"; - print " with error: " . $Status{$host}{'error'} . "\n"; - print " with owner: $owner\n\n"; - } - # Check host error - if ($Status{$host}{'error'}) - { - $Status{$host}{statusMsg} = "error: ".$Status{$host}{'error'}." / ".$Status{$host}{'reason'}; - } else { - $Status{$host}{statusMsg} = "status: ".$Status{$host}{'state'}; - } + next if $host =~ /^ /; + my $owner = $hosts_infos->{$host}->{user}; + next if (@ownerOnly and not grep {/$owner/} @ownerOnly); + my %host_conf = %{$server->ConfigDataRead($host)}; + $Status{$host}{BackupsDisable} = $host_conf{BackupsDisable}; + next if ( $Status{$host}{BackupsDisable} eq 2 and not $forceCheckOnDisabledHosts); + next if (@hostsDesired and not grep {/^$host$/} @hostsDesired); + next if (@hostsExcluded and grep {/^$host$/} @hostsExcluded); + next if ($Status{$host}{'type'} eq 'archive'); + $Status{$host}{'statusCode'} = 'OK'; + $hostCount++; + # Debug + if ($verbose == 2) + { + print "Host $host state " . $Status{$host}{'state'} . "\n"; + print " with reason: " . $Status{$host}{'reason'} . "\n"; + print " with error: " . $Status{$host}{'error'} . "\n"; + print " with owner: $owner\n\n"; + } + # Check host error + if ($Status{$host}{'error'}) + { + $Status{$host}{statusMsg} = "error: ".$Status{$host}{'error'}." / ".$Status{$host}{'reason'}; + } else { + $Status{$host}{statusMsg} = "status: ".$Status{$host}{'state'}; + } - # Check last good backup time - $Status{$host}{'lastGoodBackupDays'} = difftime(time(), $Status{$host}{'lastGoodBackupTime'}) / (3600 * 24) if ( defined $Status{$host}{'lastGoodBackupTime'} ); - if ( ! $Status{$host}{'lastGoodBackupDays'} ) { - $Status{$host}{'startDays'} = difftime(time(), $Status{$host}{'startTime'}) / (3600 * 24); - if ( $Status{$host}{'startDays'} > $critDaysOld ) { - $Status{$host}{statusMsg} .= ", no backups"; - $Status{$host}{statusCode} = 'CRITICAL'; - $statusCode = 'CRITICAL'; - } elsif ( $Status{$host}{'startDays'} > $warnDaysOld ) { - $Status{$host}{statusMsg} .= ", no backups"; - $Status{$host}{statusCode} = 'WARNING' unless ( $Status{$host}{statusCode} = 'CRITICAL' ); - $statusCode = 'WARNING' unless ( $statusCode eq 'CRITICAL' ); - } - } elsif ( $Status{$host}{'lastGoodBackupDays'} > $critDaysOld ) - { - $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f", $Status{$host}{'lastGoodBackupDays'})." days"; - $Status{$host}{statusCode} = 'CRITICAL'; - $statusCode = 'CRITICAL'; - } - elsif ( $Status{$host}{'lastGoodBackupDays'} > $warnDaysOld ) - { - $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f",$Status{$host}{'lastGoodBackupDays'})." days"; - $Status{$host}{statusCode} = 'WARNING' unless ( $Status{$host}{statusCode} = 'CRITICAL' ); - $statusCode = 'WARNING' unless ( $statusCode eq 'CRITICAL' ); - } else { - $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f",$Status{$host}{'lastGoodBackupDays'})." days"; - } - $ok_count++ if ( $Status{$host}{statusCode} eq 'OK' ); - $unknown_count++ if ( $Status{$host}{statusCode} eq 'UNKNOWN' ); - $warning_count++ if ( $Status{$host}{statusCode} eq 'WARNING' ); - $critical_count++ if ( $Status{$host}{statusCode} eq 'CRITICAL' ); + # Check last good backup time + $Status{$host}{'lastGoodBackupDays'} = difftime(time(), $Status{$host}{'lastGoodBackupTime'}) / (3600 * 24) if ( defined $Status{$host}{'lastGoodBackupTime'} ); + if ( ! $Status{$host}{'lastGoodBackupDays'} ) { + $Status{$host}{'startDays'} = difftime(time(), $Status{$host}{'startTime'}) / (3600 * 24); + if ( $Status{$host}{'startDays'} > $critDaysOld ) { + $Status{$host}{statusMsg} .= ", no backups"; + $Status{$host}{statusCode} = 'CRITICAL'; + $statusCode = 'CRITICAL'; + } elsif ( $Status{$host}{'startDays'} > $warnDaysOld ) { + $Status{$host}{statusMsg} .= ", no backups"; + $Status{$host}{statusCode} = 'WARNING' unless ( $Status{$host}{statusCode} = 'CRITICAL' ); + $statusCode = 'WARNING' unless ( $statusCode eq 'CRITICAL' ); + } + } elsif ( $Status{$host}{'lastGoodBackupDays'} > $critDaysOld ) + { + $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f", $Status{$host}{'lastGoodBackupDays'})." days"; + $Status{$host}{statusCode} = 'CRITICAL'; + $statusCode = 'CRITICAL'; + } + elsif ( $Status{$host}{'lastGoodBackupDays'} > $warnDaysOld ) + { + $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f",$Status{$host}{'lastGoodBackupDays'})." days"; + $Status{$host}{statusCode} = 'WARNING' unless ( $Status{$host}{statusCode} = 'CRITICAL' ); + $statusCode = 'WARNING' unless ( $statusCode eq 'CRITICAL' ); + } else { + $Status{$host}{statusMsg} .= ", last good backup have ".sprintf("%.1f",$Status{$host}{'lastGoodBackupDays'})." days"; + } + $ok_count++ if ( $Status{$host}{statusCode} eq 'OK' ); + $unknown_count++ if ( $Status{$host}{statusCode} eq 'UNKNOWN' ); + $warning_count++ if ( $Status{$host}{statusCode} eq 'WARNING' ); + $critical_count++ if ( $Status{$host}{statusCode} eq 'CRITICAL' ); } my $statusMsg = "BACKUPPC $statusCode"; if ( $statusCode eq 'OK' ) { - if ( $verbose && scalar(@hostsDesired) == 1 ) { - $statusMsg .= " (".$Status{$hostsDesired[0]}{statusMsg}.")"; - } else { - $statusMsg .= " ($ok_count OK)"; - } + if ( $verbose && scalar(@hostsDesired) == 1 ) { + $statusMsg .= " (".$Status{$hostsDesired[0]}{statusMsg}.")"; + } else { + $statusMsg .= " ($ok_count OK)"; + } } else { - if ( $verbose ) { - $statusMsg .= " ("; - my $first_host = 1; - foreach my $host ( keys %Status ) { - next if (@hostsDesired and not grep {/^$host$/} @hostsDesired); - next if (@hostsExcluded and grep {/^$host$/} @hostsExcluded); - next if ( $Status{$host}{BackupsDisable} ); - next if ($Status{$host}{'type'} eq 'archive'); - if ( $Status{$host}{statusCode} && $Status{$host}{statusCode} ne 'OK' ) { - $statusMsg .= ", " unless ( $first_host ); - $statusMsg .= "$host: ".$Status{$host}{statusCode}." - ".$Status{$host}{statusMsg}; - $first_host = 0 if ( $first_host ); - } - } - $statusMsg .= ")"; - } else { - $statusMsg .= " ( $ok_count OK, $unknown_count UNKNOWN, $warning_count WARNING, $critical_count CRITICAL)"; - } + if ( $verbose ) { + $statusMsg .= " ("; + my $first_host = 1; + foreach my $host ( keys %Status ) { + next if (@hostsDesired and not grep {/^$host$/} @hostsDesired); + next if (@hostsExcluded and grep {/^$host$/} @hostsExcluded); + next if ( $Status{$host}{BackupsDisable} ); + next if ($Status{$host}{'type'} eq 'archive'); + if ( $Status{$host}{statusCode} && $Status{$host}{statusCode} ne 'OK' ) { + $statusMsg .= ", " unless ( $first_host ); + $statusMsg .= "$host: ".$Status{$host}{statusCode}." - ".$Status{$host}{statusMsg}; + $first_host = 0 if ( $first_host ); + } + } + $statusMsg .= ")"; + } else { + $statusMsg .= " ( $ok_count OK, $unknown_count UNKNOWN, $warning_count WARNING, $critical_count CRITICAL)"; + } } print "$statusMsg\n"; exit $ERRORS{$statusCode}; +# vim:set sw=4 ts=4 sts=4 ft=perl expandtab: diff --git a/check_backuppc_du b/check_backuppc_du index ccc458c..3e062d5 100755 --- a/check_backuppc_du +++ b/check_backuppc_du @@ -55,37 +55,37 @@ my $statusCode = 'OK'; # Process options my $goodOpt = GetOptions( - 'q=f' => \$quota, 'quota=f' => \$quota, - 'V' => \$opt_V, 'version' => \$opt_V, - 'h' => \$opt_h, 'help' => \$opt_h, - 'H=s' => \$host, 'hostname=s' => \$host, - 'L=s' => \@hostlist, 'hostlist=s' => \@hostlist, - ); + 'q=f' => \$quota, 'quota=f' => \$quota, + 'V' => \$opt_V, 'version' => \$opt_V, + 'h' => \$opt_h, 'help' => \$opt_h, + 'H=s' => \$host, 'hostname=s' => \$host, + 'L=s' => \@hostlist, 'hostlist=s' => \@hostlist, + ); if ($opt_V) { - print "check_backuppc_du - " . $version . "\n"; - exit $ERRORS{'OK'}; + print "check_backuppc_du - " . $version . "\n"; + exit $ERRORS{'OK'}; } if ($opt_h or not $goodOpt) { - print "check_backuppc_du - " . $version . "\n"; - print "A Nagios plugin to check on BackupPC backup status.\n\n"; - print "Options:\n"; - print " --hostname,-H perl regexp to match hostnames\n"; - print " --quota,-q quota size (GB)\n"; - print " --version,-V display plugin version\n"; - print " --help,-h display this message\n\n"; - exit $ERRORS{'OK'} if $goodOpt; - exit $ERRORS{'UNKNOWN'}; + print "check_backuppc_du - " . $version . "\n"; + print "A Nagios plugin to check on BackupPC backup status.\n\n"; + print "Options:\n"; + print " --hostname,-H perl regexp to match hostnames\n"; + print " --quota,-q quota size (GB)\n"; + print " --version,-V display plugin version\n"; + print " --help,-h display this message\n\n"; + exit $ERRORS{'OK'} if $goodOpt; + exit $ERRORS{'UNKNOWN'}; } # Connect to BackupPC my $server; if (!($server = BackupPC::Lib->new)) { - print "BACKUPPC CRITICAL - Couldn't connect to BackupPC\n"; - exit $ERRORS{'CRITICAL'}; + print "BACKUPPC CRITICAL - Couldn't connect to BackupPC\n"; + exit $ERRORS{'CRITICAL'}; } my %Conf = $server->Conf(); @@ -94,8 +94,8 @@ $server->ChildInit(); my $err = $server->ServerConnect($Conf{ServerHost}, $Conf{ServerPort}); if ($err) { - print("BACKUPPC UNKNOWN - Can't connect to server ($err)\n"); - exit $ERRORS{'UNKNOWN'}; + print("BACKUPPC UNKNOWN - Can't connect to server ($err)\n"); + exit $ERRORS{'UNKNOWN'}; } # query the BackupPC server for host status @@ -114,60 +114,60 @@ my $total_count = 0; my $host_count = 0; foreach my $hostname ( sort(keys %Status) ) { - next if $hostname =~ /^\s*$/; - next if $hostname =~ /^ /; - next if ( $host && $hostname !~ m/$host/ ); - next if ( scalar(@hostlist) > 0 && not(grep /^\Q$hostname$/, @hostlist) ); + next if $hostname =~ /^\s*$/; + next if $hostname =~ /^ /; + next if ( $host && $hostname !~ m/$host/ ); + next if ( scalar(@hostlist) > 0 && not(grep /^\Q$hostname$/, @hostlist) ); - my %HostStatus = %{$Status{$hostname}}; - my %host_conf = %{$server->ConfigDataRead($hostname)}; - $HostStatus{BackupsDisable} = $host_conf{BackupsDisable}; - next if ( $HostStatus{BackupsDisable} eq 2); - next if ($HostStatus{'type'} eq 'archive'); + my %HostStatus = %{$Status{$hostname}}; + my %host_conf = %{$server->ConfigDataRead($hostname)}; + $HostStatus{BackupsDisable} = $host_conf{BackupsDisable}; + next if ( $HostStatus{BackupsDisable} eq 2); + next if ($HostStatus{'type'} eq 'archive'); - $host_count++; + $host_count++; - # Backups - my @Backups = $server->BackupInfoRead($hostname); + # Backups + my @Backups = $server->BackupInfoRead($hostname); - # Get aggregate of compressed used size (octets) - my $full_size = 0; - my $backups_count = 0; - foreach my $Backup (sort {$a->{num} cmp $b->{num}} @Backups) { - if ( $full_size == 0 ) { - $full_size += $Backup->{sizeExistComp}; - $full_size += $Backup->{sizeNewComp}; - } else { - $full_size += $Backup->{sizeNewComp}; - } - $backups_count++; - } + # Get aggregate of compressed used size (octets) + my $full_size = 0; + my $backups_count = 0; + foreach my $Backup (sort {$a->{num} cmp $b->{num}} @Backups) { + if ( $full_size == 0 ) { + $full_size += $Backup->{sizeExistComp}; + $full_size += $Backup->{sizeNewComp}; + } else { + $full_size += $Backup->{sizeNewComp}; + } + $backups_count++; + } - $total_usage += $full_size; - $total_count += $backups_count; + $total_usage += $full_size; + $total_count += $backups_count; - # Convert to Go - $full_size = sprintf("%0.2f", $full_size / 1024 / 1024 / 1024); + # Convert to Go + $full_size = sprintf("%0.2f", $full_size / 1024 / 1024 / 1024); - # Output size - $per_host_detail .= "$hostname: $backups_count backups / $full_size Go\n"; + # Output size + $per_host_detail .= "$hostname: $backups_count backups / $full_size Go\n"; } unless ( $host_count ) { - print "BACKUPPC UNKNOWN - no host matching $host\n"; - exit $ERRORS{'UNKNOWN'}; + print "BACKUPPC UNKNOWN - no host matching $host\n"; + exit $ERRORS{'UNKNOWN'}; } $total_usage = sprintf("%0.2f", $total_usage / 1024 / 1024 / 1024); if ( $total_usage >= $quota ) { - print "BACKUPPC CRITICAL - $total_usage Go used / $quota Go allocated\n"; - $statusCode = 'CRITICAL'; + print "BACKUPPC CRITICAL - $total_usage Go used / $quota Go allocated\n"; + $statusCode = 'CRITICAL'; } elsif ( $total_usage >= $quota * 0.90 ) { - print "BACKUPPC WARNING - $total_usage Go used / $quota Go allocated\n"; - $statusCode = 'WARNING'; + print "BACKUPPC WARNING - $total_usage Go used / $quota Go allocated\n"; + $statusCode = 'WARNING'; } else { - print "BACKUPPC OK - $total_usage Go used / $quota Go allocated\n"; + print "BACKUPPC OK - $total_usage Go used / $quota Go allocated\n"; } print "Total of $total_count backups with cumulative compressed size of $total_usage Go for $host_count active hosts\n"; @@ -175,4 +175,4 @@ print $per_host_detail; exit $ERRORS{$statusCode}; - +# vim:set sw=4 ts=4 sts=4 ft=perl expandtab: